Discussion:
[Aarch64] Fix warning in _sbrk
Christophe Lyon
2018-10-01 21:34:22 UTC
Permalink
Hi,

While building newlib for Aarch64, I noticed a warning in _sbrk. This
small patch fixes it the same way it is done in the Arm version.

OK?

Christophe
Christophe Lyon
2018-10-05 09:19:46 UTC
Permalink
ping?
Post by Christophe Lyon
Hi,
While building newlib for Aarch64, I noticed a warning in _sbrk. This
small patch fixes it the same way it is done in the Arm version.
OK?
Christophe
Richard Earnshaw (lists)
2018-10-05 12:22:42 UTC
Permalink
Post by Christophe Lyon
Hi,
While building newlib for Aarch64, I noticed a warning in _sbrk. This
small patch fixes it the same way it is done in the Arm version.
OK?
Pushed.

R.
Post by Christophe Lyon
Christophe
newlib-5.txt
commit 828bf40d0d822425cbfb0cd69dbb4e48cca66592
Date: Mon Oct 1 19:08:40 2018 +0000
[Aarch64] Fix warning in _sbrk
* libgloss/aarch64/syscalls.c (_sbrk): Cast "__heap_limit" to
"char *".
diff --git a/libgloss/aarch64/syscalls.c b/libgloss/aarch64/syscalls.c
index 8198d3e..e6dd4bd 100644
--- a/libgloss/aarch64/syscalls.c
+++ b/libgloss/aarch64/syscalls.c
@@ -642,7 +642,7 @@ _sbrk (int incr)
if ((heap_end + incr > stack_ptr)
/* Honour heap limit if it's valid. */
- || ((__heap_limit != 0xcafedead) && (heap_end + incr > __heap_limit)))
+ || ((__heap_limit != 0xcafedead) && (heap_end + incr > (char *)__heap_limit)))
{
/* Some of the libstdc++-v3 tests rely upon detecting
out of memory errors, so do not abort here. */
Loading...