[PATCH] Fix stdlib/arc4random and search/hash for 16-bit targets

[j***@beniston.com]

Hi,

The attached patches fix stdlib/arc4random.c and search/hash on 16-bit
targets.

Incidentally, why is the Berkley DB hash code in Newlib? The functions don't
appear to be exported in any headers (and have non-standard names) and I
couldn't see it being used internally.

Cheers,
Jon

[Corinna Vinschen]

Post by j***@beniston.com
Hi,
The attached patches fix stdlib/arc4random.c and search/hash on 16-bit
targets.

First patch pushed.

Please fix the commit message of the 2nd patch. The entire text is
treated as summary. Please see the DISCUSSION section of `man git-commit'.

Post by j***@beniston.com
Incidentally, why is the Berkley DB hash code in Newlib? The functions don't
appear to be exported in any headers (and have non-standard names) and I
couldn't see it being used internally.

What does the git history indicate?


Thanks,
Corinna

[j***@beniston.com]

Hi Corinna,

Please fix the commit message of the 2nd patch. The entire text is treated as summary.
Please see the DISCUSSION section of `man git-commit'.

Ok. Updated patch attached, thanks.

Post by j***@beniston.com
Incidentally, why is the Berkley DB hash code in Newlib? The functions
don't appear to be exported in any headers (and have non-standard
names) and I couldn't see it being used internally.

What does the git history indicate?

Nothing that I could see initially. Looking through the mailing lists, it seems it was initially added to support ndbm.h/ndbm.c, but they were removed in 2002.

https://sourceware.org/ml/newlib/2002/msg00268.html

Cheers,
Jon

[Corinna Vinschen]

Post by j***@beniston.com
Hi Corinna,

Please fix the commit message of the 2nd patch. The entire text is treated as summary.
Please see the DISCUSSION section of `man git-commit'.

Ok. Updated patch attached, thanks.

Pushed.

Post by j***@beniston.com

Post by j***@beniston.com
Incidentally, why is the Berkley DB hash code in Newlib? The functions
don't appear to be exported in any headers (and have non-standard
names) and I couldn't see it being used internally.

What does the git history indicate?

Nothing that I could see initially. Looking through the mailing lists, it seems it was initially added to support ndbm.h/ndbm.c, but they were removed in 2002.
https://sourceware.org/ml/newlib/2002/msg00268.html

Hmm, no idea. Given that it isn't exported, I guess a patch
removing the unused code wouldn't hurt :)


Thanks,
Corinna